Skip to content

refactor: use isLeapYear#1638

Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
vil02:use_isLeapYear
Mar 7, 2024
Merged

refactor: use isLeapYear#1638
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
vil02:use_isLeapYear

Conversation

@vil02
Copy link
Copy Markdown
Member

@vil02 vil02 commented Mar 5, 2024

Open in Gitpod know more

Describe your change:

This PR:

  • applies the isLeapYear,
  • reorganizes the tests of GetMonthDays - note the change of the year in one of the test cases (I do not want to create an illusion that this function should be uses for years before 1582).

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.94%. Comparing base (d8cfdcd) to head (00aca32).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   83.93%   83.94%           
=======================================
  Files         377      377           
  Lines       19733    19727    -6     
  Branches     2921     2917    -4     
=======================================
- Hits        16563    16559    -4     
+ Misses       3170     3168    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vil02 vil02 marked this pull request as ready for review March 5, 2024 18:21
@vil02 vil02 marked this pull request as draft March 5, 2024 18:22
@vil02 vil02 marked this pull request as ready for review March 5, 2024 18:27
@vil02 vil02 force-pushed the use_isLeapYear branch 2 times, most recently from c523049 to 5faf0a5 Compare March 5, 2024 18:34
@vil02
Copy link
Copy Markdown
Member Author

vil02 commented Mar 5, 2024

@appgurueu or @raklaptudirm could you please re-run the UploadCoverageReport (if needed). It failed due to: The server encountered a temporary error and could not complete your request.

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Mar 5, 2024

(Just amended your last commit and force pushed to trigger a rerun of CI)

@vil02
Copy link
Copy Markdown
Member Author

vil02 commented Mar 5, 2024

(Just amended your last commit and force pushed to trigger a rerun of CI)

I could do the same, but I did not want to lose your approval. Thanks!

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Mar 5, 2024

I could do the same, but I did not want to lose your approval. Thanks!

Heh, right. Sometimes our strict repo config frustrates me a bit.

@raklaptudirm raklaptudirm merged commit 4a4ed57 into TheAlgorithms:master Mar 7, 2024
@vil02 vil02 deleted the use_isLeapYear branch March 7, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vil02 @codecov-commenter @appgurueu @raklaptudirm