Skip to content

changing file names to follow UpperCamelCase (PascalCase) style.#154

Merged
cclauss merged 5 commits intoTheAlgorithms:masterfrom
itsvinayak:master
May 6, 2020
Merged

changing file names to follow UpperCamelCase (PascalCase) style.#154
cclauss merged 5 commits intoTheAlgorithms:masterfrom
itsvinayak:master

Conversation

@itsvinayak
Copy link
Copy Markdown
Member

@itsvinayak itsvinayak commented May 6, 2020

Welcome to Javascript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Javascript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@itsvinayak itsvinayak requested a review from cclauss May 6, 2020 13:03
@itsvinayak
Copy link
Copy Markdown
Member Author

itsvinayak commented May 6, 2020

@cclauss test fails due to linear-algebra-javascript name change to Linear-Algebra-Javascript

@cclauss
Copy link
Copy Markdown
Member

cclauss commented May 6, 2020 •
edited
Loading

Data-Structures/Tree/Binary Search Tree.js contains spaces.

Leave linear algebra as is for now. We can attack that in a separate PR.

@itsvinayak
Copy link
Copy Markdown
Member Author

itsvinayak commented May 6, 2020

Data-Structures/Tree/Binary Search Tree.js contains spaces.

Leave linear algebra as is for now. We can attack that in a separate PR.

done

@cclauss cclauss merged commit a052808 into TheAlgorithms:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss Awaiting requested review from cclauss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itsvinayak @cclauss