Skip to content

feat: Added MD5 hashing algorithm#1519

Merged
raklaptudirm merged 16 commits intoTheAlgorithms:masterfrom
ManpreetXSingh:md5
Oct 30, 2023
Merged

feat: Added MD5 hashing algorithm#1519
raklaptudirm merged 16 commits intoTheAlgorithms:masterfrom
ManpreetXSingh:md5

Conversation

@ManpreetXSingh
Copy link
Copy Markdown
Contributor

@ManpreetXSingh ManpreetXSingh commented Oct 12, 2023 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu requested changes Oct 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is pretty messy because it juggles various representations of bytes that aren't really suitable (strings of bits encoded as ASCII 0 / 1 etc.)
It should be changed to just use Uint8Array wherever byte arrays are needed, and simply numbers wherever 4 byte "words" are needed. The string representations (and the code for dealing with them) should be gotten rid of entirely.

Also needs tests.

@ManpreetXSingh
Copy link
Copy Markdown
Contributor Author

ManpreetXSingh commented Oct 20, 2023

Hi @appgurueu,
Thanks for the feedback!
Actually I'm quite new to the js world. I looked at the SHA implementations in the nearby files and assumed that it's the right way to do it. I'll try my best to fix the issues and make the code cleaner.

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 21, 2023

[...] I looked at the SHA implementations in the nearby files and assumed that it's the right way to do it. [...]

Ah, sorry about that. We have much legacy code lying around that needs to be refactored and definitely isn't a good example. We should make it more clear in the contribution guidelines that much of the legacy codebase shouldn't be taken as a good example.

@ManpreetXSingh
Copy link
Copy Markdown
Contributor Author

ManpreetXSingh commented Oct 28, 2023

Hi @appgurueu,
I believe I have implemented all of the requested changes. Please let me know if any additional adjustments are needed.

appgurueu
appgurueu reviewed Oct 28, 2023
View reviewed changes
appgurueu
appgurueu reviewed Oct 28, 2023
View reviewed changes
@appgurueu appgurueu added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 28, 2023
@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 28, 2023

Adding the hacktoberfest-accepted label in case we don't get this merged before October ends; the PR is almost there!

@raklaptudirm raklaptudirm merged commit 889d9c3 into TheAlgorithms:master Oct 30, 2023
@ManpreetXSingh
Copy link
Copy Markdown
Contributor Author

ManpreetXSingh commented Oct 30, 2023 •
edited
Loading

Thanks! 😊

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 30, 2023

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ManpreetXSingh @appgurueu @raklaptudirm