Merged
Conversation
Member
|
Not a fan of this approach. The linter is correct that Array prototype is read only. Can't we find a way to resolve this that does not cause the linter to complain. |
Member
Author
|
Yes, but we have to change the entire code
We have to pass array and than sort
I guess
Vinayak sharma
9259888898
IERT allahabad
CSE 3rd year
…On Tue, 5 May, 2020, 6:08 PM Christian Clauss, ***@***.***> wrote:
Not a fan of this approach. The linter is correct that Array prototype is
read only.
Can't we find a way to resolve this that does not cause the linter to
complain.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#150 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIDL6MWSTEZGLSE7BDM3EATRQACE7ANCNFSM4MZQV5NA>
.
|
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/* eslint no-extend-native: ["off", { "exceptions": ["Object"] }] */
this can be used to turn off eslint, as according to eslint extending native objects is bad