Feat: TwoSum function created with test cases#1399
Merged
raklaptudirm merged 12 commits intoTheAlgorithms:masterfrom Oct 4, 2023
developerr-ayush:master
Merged
Feat: TwoSum function created with test cases#1399raklaptudirm merged 12 commits intoTheAlgorithms:masterfrom developerr-ayush:master
raklaptudirm merged 12 commits intoTheAlgorithms:masterfrom
developerr-ayush:master
Conversation
Feature two sum function
developerr-ayush
requested review from
appgurueu and
raklaptudirm
as code owners
Contributor
Author
|
hey i have registered in Hacktoberfest so does this count? |
appgurueu
requested changes
Oct 2, 2023
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
- You should use a proper JSDoc comment.
- The
Mapshould actually be an ES6 Map (rather than a dictionary which coerces keys to strings). - You should use Jest's
eachfor the test cases. I'd probably divide them into two sets, one of tests without and the other of tests with a solution for the two sum problem.
Contributor
Author
|
i have made the following changes if I am wring at some please them can you let me know. |
appgurueu
approved these changes
Oct 3, 2023
raklaptudirm
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.