Skip to content

Add Length Conversion#1390

Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
0APOCALYPSE0:master
Oct 2, 2023
Merged

Add Length Conversion#1390
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
0APOCALYPSE0:master

Conversation

@0APOCALYPSE0
Copy link
Copy Markdown
Contributor

@0APOCALYPSE0 0APOCALYPSE0 commented Oct 1, 2023 •
edited
Loading

Open in Gitpod know more

Feature

I have added Algorithms for Length Conversion.
Issue #1391

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu requested changes Oct 1, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is interesting enough algorithmically yet; the code also suffers from unnecessary code duplication: You've effectively hardcoded the cartesian product of {mile, kilometer, meter, centimeter, feet, yard, inch} with itself (and excepting self-to-self, of course).

I think you should change your function to be something like function LengthConversion(length, fromUnit, toUnit) where fromUnit and toUnit are standard abbreviations like km for kilometre or similar. Then you should use a lookup dict which maps these to meters. The calculation then becomes length * meters[fromUnit] / meters[toUnit], and you get away with a fraction of the code.

@0APOCALYPSE0
Copy link
Copy Markdown
Contributor Author

0APOCALYPSE0 commented Oct 1, 2023

@appgurueu I have updated. Could you please review it now?
Thanks

appgurueu
appgurueu reviewed Oct 1, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now please

@0APOCALYPSE0
Add Length Conversion
b11d68a 
Update Length Conversion

resolved comments
@raklaptudirm raklaptudirm merged commit 6291d4b into TheAlgorithms:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0APOCALYPSE0 @appgurueu @raklaptudirm