Skip to content

feat: New String Algorithm for LengthofLongestSubstringWithoutRepeati…#1389

Merged
raklaptudirm merged 8 commits intoTheAlgorithms:masterfrom
Abhijit-033:master
Oct 2, 2023
Merged

feat: New String Algorithm for LengthofLongestSubstringWithoutRepeati…#1389
raklaptudirm merged 8 commits intoTheAlgorithms:masterfrom
Abhijit-033:master

Conversation

@Abhijit-033
Copy link
Copy Markdown
Contributor

@Abhijit-033 Abhijit-033 commented Oct 1, 2023 •
edited
Loading

…ngCharacters

Open in Gitpod know more

Describe your change:

Added an Algorithm with its Test

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Oct 1, 2023
View reviewed changes
@Abhijit-033 Abhijit-033 requested a review from appgurueu October 2, 2023 04:30
appgurueu
appgurueu approved these changes Oct 2, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also use each for the tests.

@raklaptudirm raklaptudirm merged commit 36dcff8 into TheAlgorithms:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Abhijit-033 @appgurueu @raklaptudirm