Skip to content

added algo for checking the number is power of four or not#1360

Merged
raklaptudirm merged 6 commits into
TheAlgorithms:masterfrom
dev-madhurendra:checkPowerOf4
Sep 22, 2023
Merged

added algo for checking the number is power of four or not#1360
raklaptudirm merged 6 commits into
TheAlgorithms:masterfrom
dev-madhurendra:checkPowerOf4

Conversation

@dev-madhurendra

@dev-madhurendra dev-madhurendra commented Sep 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Sep 11, 2023
View reviewed changes
Comment thread Bit-Manipulation/IsPowerofFour.js Outdated
appgurueu
appgurueu requested changes Sep 11, 2023
View reviewed changes

@appgurueu appgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, please use a proper JSDoc comment; I'd also remove most of the explanation, esp. those items which are fully redundant with the code ("[a]nd the and of n&n-1 will be 0" f.e.).

appgurueu
appgurueu reviewed Sep 12, 2023
View reviewed changes

@appgurueu appgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, please use proper JSDoc comments.

@raklaptudirm
raklaptudirm merged commit 4fe8a67 into TheAlgorithms:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes
@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dev-madhurendra @appgurueu @raklaptudirm