Skip to content

feat: Ciphers/MorseCode Algorithm#1315

Merged
raklaptudirm merged 18 commits intoTheAlgorithms:masterfrom
mrmagic2020:cipher_morse
May 1, 2023
Merged

feat: Ciphers/MorseCode Algorithm#1315
raklaptudirm merged 18 commits intoTheAlgorithms:masterfrom
mrmagic2020:cipher_morse

Conversation

@mrmagic2020
Copy link
Copy Markdown
Contributor

@mrmagic2020 mrmagic2020 commented Apr 28, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@mrmagic2020
Copy link
Copy Markdown
Contributor Author

mrmagic2020 commented Apr 28, 2023

probably ignore the style check of MorseCode.js, since I have to store the morse code with its corresponding string character; or there might be a better way to do this

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Apr 28, 2023

probably ignore the style check of MorseCode.js, since I have to store the morse code with its corresponding string character; or there might be a better way to do this

It's telling you that there is no need to quote these properties. You should be able to safely remove the quotes. In the case of the digits this might indeed seem dubious, but I think it plays out fine because of JS's string coercion.

@mrmagic2020
Copy link
Copy Markdown
Contributor Author

mrmagic2020 commented Apr 28, 2023

probably ignore the style check of MorseCode.js, since I have to store the morse code with its corresponding string character; or there might be a better way to do this

It's telling you that there is no need to quote these properties. You should be able to safely remove the quotes. In the case of the digits this might indeed seem dubious, but I think it plays out fine because of JS's string coercion.

Yep! Tested the new code and it worked all the same.

@raklaptudirm raklaptudirm merged commit 331a4d2 into TheAlgorithms:master May 1, 2023
@mrmagic2020 mrmagic2020 deleted the cipher_morse branch May 1, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrmagic2020 @appgurueu @raklaptudirm