Skip to content

chore: add reverse to singly linked list#1241

Merged
raklaptudirm merged 4 commits intoTheAlgorithms:masterfrom
CTRL-KHS:master
Oct 30, 2022
Merged

chore: add reverse to singly linked list#1241
raklaptudirm merged 4 commits intoTheAlgorithms:masterfrom
CTRL-KHS:master

Conversation

@CTRL-KHS
Copy link
Copy Markdown
Contributor

@CTRL-KHS CTRL-KHS commented Oct 29, 2022 •
edited by gitpod-io bot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@CTRL-KHS
Copy link
Copy Markdown
Contributor Author

CTRL-KHS commented Oct 29, 2022

All the tests are passing and the standard style is followed too.

appgurueu
appgurueu requested changes Oct 29, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How is this a fix?
  2. Please integrate this into https://github.com/TheAlgorithms/JavaScript/blob/master/Data-Structures/Linked-List/SinglyLinkedList.js; this definitely should not be its own class.

@CTRL-KHS CTRL-KHS changed the title Fix: Reverse Singly Linked List Added Reverse in Singly Linked List where each node has single integer Oct 29, 2022
@CTRL-KHS CTRL-KHS requested a review from appgurueu October 29, 2022 14:54
@CTRL-KHS
Copy link
Copy Markdown
Contributor Author

CTRL-KHS commented Oct 29, 2022

Please review the changes. Function added in SinglyLinkedList.js and tested too

appgurueu
appgurueu reviewed Oct 29, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 29, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 29, 2022
View reviewed changes
@CTRL-KHS CTRL-KHS changed the title Added Reverse in Singly Linked List where each node has single integer Added Reverse in Singly Linked List Oct 29, 2022
@CTRL-KHS CTRL-KHS requested a review from appgurueu October 29, 2022 17:15
@CTRL-KHS
Copy link
Copy Markdown
Contributor Author

CTRL-KHS commented Oct 29, 2022

@raklaptudirm Please review this PR

@raklaptudirm raklaptudirm changed the title Added Reverse in Singly Linked List chore: add reverse to singly linked list Oct 30, 2022
@raklaptudirm raklaptudirm merged commit c5101e3 into TheAlgorithms:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CTRL-KHS @appgurueu @raklaptudirm