Skip to content

Updates Discord Invite Link#1202

Merged
appgurueu merged 4 commits intoTheAlgorithms:masterfrom
zafar-hussain:master
Oct 17, 2022
Merged

Updates Discord Invite Link#1202
appgurueu merged 4 commits intoTheAlgorithms:masterfrom
zafar-hussain:master

Conversation

@zafar-hussain
Copy link
Copy Markdown
Contributor

@zafar-hussain zafar-hussain commented Oct 17, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

A discord link in Readme.md was updated to the new link to discord invites, namely "https://the-algorithms.com/discord/"

@zafar-hussain
Copy link
Copy Markdown
Contributor Author

zafar-hussain commented Oct 17, 2022

@reviewers

please, if you can add "hacktoberfest-accepted" label, if this PR is fulfilled

cheers

appgurueu
appgurueu reviewed Oct 17, 2022
View reviewed changes
@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 17, 2022

@reviewers

please, if you can add "hacktoberfest-accepted" label, if this PR is fulfilled

cheers

I'm afraid this PR is probably too trivial to be accepted (I'm also wary of using the TheAlgorithms link rather than a direct link to the Discord).

zafar-hussain
zafar-hussain commented Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@zafar-hussain zafar-hussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change the link back to the original, or leave it as it is?

Sorry for a newbie question by me

cheers

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 17, 2022 •
edited
Loading

Should I change the link back to the original, or leave it as it is?

Changing it back would render this PR detrimental. I'm trying to determine whether we should close the PR. @raklaptudirm

@Panquesito7 would probably want the link to be updated (possible rationale: ability to use a redirect and change the underlying link, hopefully no tracking intended).

@Panquesito7 Panquesito7 added the chore General improvement label Oct 17, 2022
Panquesito7
Panquesito7 requested changes Oct 17, 2022
View reviewed changes
Panquesito7
Panquesito7 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🎉

@appgurueu appgurueu merged commit 8b5d006 into TheAlgorithms:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm

Assignees

No one assigned

Labels

chore General improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zafar-hussain @appgurueu @Panquesito7