Skip to content

algorithm: check if integer is palindrome#1177

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
changicho:feature/palindrome-number
Oct 15, 2022
Merged

algorithm: check if integer is palindrome#1177
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
changicho:feature/palindrome-number

Conversation

@changicho
Copy link
Copy Markdown
Contributor

@changicho changicho commented Oct 13, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu requested changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems redundant to me: Converting a number to string - as is done below - will work just fine (because a number-to-string conversion ultimately does what you're doing here, albeit with more overhead). This is also missing tests. Also please move it to a different folder - say Math - because this definitely doesn't belong in String.

@changicho
Copy link
Copy Markdown
Contributor Author

changicho commented Oct 14, 2022

This seems redundant to me: Converting a number to string - as is done below - will work just fine (because a number-to-string conversion ultimately does what you're doing here, albeit with more overhead). This is also missing tests. Also please move it to a different folder - say Math - because this definitely doesn't belong in String.

I create new function in 'Math' folder, and remove that belong in 'String' in new commit

Please check it. Thanks

@raklaptudirm raklaptudirm changed the title Add check number case in IsPalindrome algorithm: check if integer is palindrome Oct 15, 2022
@raklaptudirm raklaptudirm merged commit 45f0b7c into TheAlgorithms:master Oct 15, 2022
@changicho changicho deleted the feature/palindrome-number branch October 15, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@changicho @appgurueu @raklaptudirm