Add the Collatz Conjecture#1022
Merged
raklaptudirm merged 15 commits intoTheAlgorithms:masterfrom May 26, 2022
Exortions:master
Merged
Add the Collatz Conjecture#1022raklaptudirm merged 15 commits intoTheAlgorithms:masterfrom Exortions:master
raklaptudirm merged 15 commits intoTheAlgorithms:masterfrom
Exortions:master
Conversation
raklaptudirm
requested changes
May 24, 2022
Member
raklaptudirm
left a comment
raklaptudirm
left a comment
There was a problem hiding this comment.
Not everyone is familiar with the collatz conjecture. Add some explanatory comments and Wikipedia links.
Contributor
Author
|
Yep, will add those tomorrow. |
appgurueu
requested changes
May 24, 2022
appgurueu
reviewed
May 24, 2022
appgurueu
reviewed
May 24, 2022
raklaptudirm
requested changes
May 24, 2022
Co-authored-by: Rak Laptudirm <rak@laptudirm.com>
Collaborator
|
This is currently unable to disprove the Collatz conjecture as it just won't halt as it lacks cycle detection (which would have to be implemented using a hashmap); it can merely show that certain sequences don't disprove the Collatz conjecture. I suggest focusing on the sequence rather than the conjecture. |
Collaborator
|
Still reads "collatz conjecture" in numerous places... |
Contributor
Author
As in the comments? Or the code? |
appgurueu
approved these changes
May 25, 2022
raklaptudirm
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.