An improvement on Ficbonacci function using DP

// My code just improves a little
// Feel free to ask me questions

function dp_ficbo(n)
{
var val = [];
for ( let i = 0; i <= n; i++)
{
val[i] = 0;
}

	if ( n == 1 || n == 2)
	{
		return 1;
	}
	else
	{
		val[1] = 1;
		val[2] = 2;

		for ( let i = 3; i <= n; i++ )
		{
			val[i] = val[i - 1] + val[i - 2];
		}
	}

	return val[n - 1];
}

console.log(dp_ficbo(20));

If you feel you can make a better implementation feel free to make a PR

I do not understand what PR means. If it is a sarcasm feel free not to reply.

No it is not sarcasm

Sorry if you misunderstood

PR means Pull Request which means updating the code of the repo with the better approach so that I can merge it in the repository.

I have given to link for you to check just in case if you are new to GitHub

https://help.github.com/articles/about-pull-requests/

Thank you for your explanation.
I will use pull request to share the code.

@duongtq

@duongtq This lines are needless

for ( let i = 0; i <= n; i++)
{
    val[i] = 0;
}

Because you used dynamic arrays in javascript.

@duongtq

@duongtq

val[1] = 1;
val[2] = 2;

Begin with index 0. Change your for-loop according to index 0

I would like to work on this by providing the solution of the Fibonacci sequence from the Brute Force Approach to the Top-Down and Bottom-Up Dynamic Approach.

can i make a pull request...i can update the code by applying dynamic programming.

Is this issue still open ? I would like to work on it.

@Satzyakiz

there is already this function available

const dict = new Map()

const FibonacciRecursiveDP = (stairs) => {
  if (stairs <= 0) return 0
  if (stairs === 1) return 1

  // Memoize stair count
  if (dict.has(stairs)) return dict.get(stairs)

  const res =
    FibonacciRecursiveDP(stairs - 1) + FibonacciRecursiveDP(stairs - 2)

  dict.set(stairs, res)

  return res
}

if you can improve it or add something new then go for it @Satzyakiz, you are most welcome

@itsvinayak

Maybe something like this :

function fibonacci(n) {
  const fibArr = [0,1];

  for(let i=2; i<=n; i++){
    fibArr.push( fibArr[i-1] + fibArr[i-2] );
  }

  return fibArr[n-1];
}

This is nothing new, just avoiding the recursive calls. @itsvinayak

@Satzyakiz

@Satzyakiz you can make a separate function for this approach in this file and send a PR

Where should I keep it ? In Algorithms/Dynamic-Programming/ ?

In same file make a function Vinayak sharma 9259888898 IERT allahabad CSE 3rd year

…

On Fri, 8 May, 2020, 4:15 PM Satzyakiz, ***@***.***> wrote: Where should I keep it ? In Algorithms/Dynamic-Programming/ ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIDL6MUFS2LBGN7MVWNVUXTRQPPFRANCNFSM4GNA3YZQ> .

many new algorithms are added on this topic #159

Navigation Menu

Repository navigation

An improvement on Ficbonacci function using DP #81

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

An improvement on Ficbonacci function using DP #81

Description

Activity

the-codingninja commented on Jan 3, 2019

duongtq commented on Jan 3, 2019

the-codingninja commented on Jan 3, 2019

duongtq commented on Jan 3, 2019

christianbender commented on Feb 17, 2019

christianbender commented on Feb 17, 2019

archanaserver commented on Oct 6, 2019

ritwikchakraborty123 commented on Mar 22, 2020

Satzyakiz commented on May 8, 2020

itsvinayak commented on May 8, 2020

Satzyakiz commented on May 8, 2020

itsvinayak commented on May 8, 2020

Satzyakiz commented on May 8, 2020

itsvinayak commented on May 8, 2020

itsvinayak commented on May 9, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions