Repository navigation
Files that are not compliant with standardjs #139
Description
The following FilePaths fail npx standard FilePath and can not be fixed using the --fix option.
- https://standardjs.com
- Javascript/linear-algebra-javascript/test/test.js
- Javascript/linear-algebra-javascript/src/la_lib.js
- Remove
|| truefrom thenpx standardcommand
- Javascript/Ciphers/keyFinder.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Ciphers/vigenereCipher.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Conversions/DecimalToHex.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Data Structures/Graph/Graph.js Data Structures/Graph and Sorting files #141
- Javascript/Data Structures/Heap/MinPriorityQueue.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Data Structures/Linked List/DoublyLinkedList.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Data Structures/Queue/Queue.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Data Structures/Stack/Stack.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Data Structures/Tree/Binary Search Tree.js Fixing non compliant files (Ciphers, Conversions and Data Structures) #140
- Javascript/Hashes/SHA256.js
- Javascript/Search/linearSearch.js search/linearSearch.js #143
- Javascript/Sorts/TopologicalSort.js Data Structures/Graph and Sorting files #141
- Javascript/Sorts/bogoSort.js sort/ #150
- Javascript/Sorts/bucketSort.js Data Structures/Graph and Sorting files #141
- Javascript/Sorts/combSort.js Data Structures/Graph and Sorting files #141
- Javascript/Sorts/cycleSort.js Data Structures/Graph and Sorting files #141
- Javascript/Sorts/heapSort.js sort/ #150
- Javascript/Sorts/selectionSort.js Data Structures/Graph and Sorting files #141
- Javascript/Sorts/wiggleSort.js sort/ #150
- Javascript/maths/DijkstraSmallestPath.js DijkstraSmallestPath.js: Standardjs fixes #147
- Javascript/maths/abs.js abs.js: abs_val() --> absVal() for standardjs #144
- Javascript/maths/factorial.js factorial.js: Standardjs fixes #145
- Javascript/maths/find_lcm.js find_lcm.js: Standardjs fixes #146
- Javascript/maths/graph.js
Reacted by vinayak
Metadata
Metadata
Labels
No labels
Activity
juliano-nunes commentedon May 3, 2020
Hey @itsvinayak, let me know if you need help :)
cclauss commentedon May 3, 2020
This work should not all be done in one pull request (to have mercy on project maintainers) and should not all be done by one developer. So if you wish to help, just fix a few files and submit a PR. You do not need to wait for permission, just dig in. ;-)
juliano-nunes commentedon May 4, 2020
Ok @cclauss, thank you. I have opened a PR to fix the first ones (Ciphers, Conversions and Data Structures).
cclauss commentedon May 4, 2020
Nice. I look forward to seeing #140 reviewed and landed. For future pull requests, to make this process easier for the reviewers, please try to do those files where standard has just one or two objections first. This will build momentum and should quickly get the long list down to a reasonable size. For the files that require complex changes, please try to do one file per pull request.
Also, please look at https://github.com/TheAlgorithms/Javascript/actions to follow the standard testing progress. Once all files are compliant, we should remove the
|| truefrom our GitHub Action to mandate compliance on future PRs. I added this at the end of our task list above. Thanks!itsvinayak commentedon May 4, 2020
#140 has been merged and PR #141 has been
createdmerged.factorial.js: Standardjs fixes
itsvinayak commentedon May 4, 2020
#147 is merged
cclauss commentedon May 4, 2020
6 files left... Do you know how to solve the problem with the sorts?
cclauss commentedon May 5, 2020
@Nur69 Would you be willing to see if you can get Javascript/maths/graph.js to pass https://standardjs.com ? I tried but was unable to get it to pass.
itsvinayak commentedon May 5, 2020
no, there is a problem with /linear-algebra-javascript/ and /sorts/ Algorithms
cclauss commentedon May 5, 2020
Sort issue is
https://www.google.com/search?q=Array+prototype+is+read+only%2C+properties+should+not+be+added.
Maybe http://linterrors.com/js/extending-prototype-of-native-object
itsvinayak commentedon May 5, 2020
Javascript/maths/graph.jshas been fixed in this commititsvinayak commentedon May 5, 2020
#152
Fetching last changes (#1)