Fix AbsoluteMin comparison by absolute magnitude#7540
Draft
kush2439p wants to merge 2 commits into
Draft
Conversation
kush2439p
force-pushed
the
agent/fix-absolute-min-magnitude
branch
from
July 23, 2026 07:17
7c1b1ed to
ecf7664
Compare
Author
|
This PR corrects AbsoluteMin.getMinValue to compare values by absolute magnitude while returning the original signed value. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7540 +/- ##
============================================
- Coverage 80.32% 80.31% -0.01%
- Complexity 7402 7404 +2
============================================
Files 812 812
Lines 23911 23915 +4
Branches 4704 4706 +2
============================================
+ Hits 19206 19208 +2
- Misses 3944 3945 +1
- Partials 761 762 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
AbsoluteMin.getMinValuefiltered candidates using their absolute values, but then updated the result withMath.minon the raw signed values. A larger-magnitude negative number could therefore replace the correct candidate.Validation
javaccompilation and direct behavior checks passedgit diff --checkpassedmvn -Dtest=AbsoluteMinTest testreached test compilation, but the upstream checkout has unrelated missing-class compilation failures across existing tests before Surefire can select the focused testFixes #7537