conversion binary to hexadecimal#694
Merged
yanglbme merged 5 commits intoTheAlgorithms:Developmentfrom Jan 30, 2019
Merged
Conversation
conversion binary to hexadecimal
yanglbme
requested changes
Jan 28, 2019
| * @return The hexadecimal number | ||
| */ | ||
|
|
||
| public String binToHex(int binary) { |
Member
There was a problem hiding this comment.
The binary number may have 32bits or 64bits, so it's unsuitable to use int type.
resolving comment
yanglbme
requested changes
Jan 28, 2019
| public void testBinaryToHexadecimal(){ | ||
| BinaryToHexadecimal binaryToHexadecimal = new BinaryToHexadecimal(); | ||
| Assert.assertEquals("Incorrect Conversion", "2A", binaryToHexadecimal.binToHex(101010)); | ||
| Assert.assertEquals("Incorrect Conversion", "24", binaryToHexadecimal.binToHex(100100)); |
Member
There was a problem hiding this comment.
How about the test case 1010101010101010101010101010101010101010101010101010101010101010101010100001 (64 bits)
Author
There was a problem hiding this comment.
Hi, i had to use BigInteger to resolve that case you commented.
yanglbme
reviewed
Jan 30, 2019
Member
yanglbme
left a comment
yanglbme
left a comment
There was a problem hiding this comment.
@arodriguez33 Thanks for your changes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conversion binary to hexadecimal