Skip to content

Add Longest Subarray With Sum Less Than or Equal to K algorithm and t…#6042

Merged
siriak merged 8 commits intoTheAlgorithms:masterfrom
Chiefpatwal:newbranch1
Oct 27, 2024
Merged

Add Longest Subarray With Sum Less Than or Equal to K algorithm and t…#6042
siriak merged 8 commits intoTheAlgorithms:masterfrom
Chiefpatwal:newbranch1

Conversation

@Chiefpatwal
Copy link
Copy Markdown
Contributor

@Chiefpatwal Chiefpatwal commented Oct 27, 2024 •
edited
Loading

…ests

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 27, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.40%. Comparing base (a2e526b) to head (81f1e00).
⚠️ Report is 534 commits behind head on master.

Files with missing lines Patch % Lines
...ngwindow/LongestSubarrayWithSumLessOrEqualToK.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6042      +/-   ##
============================================
+ Coverage     72.37%   72.40%   +0.02%     
- Complexity     4978     4983       +5     
============================================
  Files           652      653       +1     
  Lines         17564    17574      +10     
  Branches       3384     3386       +2     
============================================
+ Hits          12712    12724      +12     
+ Misses         4372     4371       -1     
+ Partials        480      479       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Chiefpatwal
Copy link
Copy Markdown
Contributor Author

Chiefpatwal commented Oct 27, 2024

I have added the Longest Subarray with Sum Less Than or Equal to K algorithm along with its corresponding tests. However, I am encountering issues with the Infer run check, which is failing. I'm currently trying to understand the underlying causes of the failure. Any feedback or guidance would be greatly appreciated!

@Chiefpatwal Chiefpatwal marked this pull request as ready for review October 27, 2024 14:21
@siriak
Copy link
Copy Markdown
Member

siriak commented Oct 27, 2024

The issue with infer is that:
image

@siriak
Copy link
Copy Markdown
Member

siriak commented Oct 27, 2024

This issue also fails #6009

@Chiefpatwal
Copy link
Copy Markdown
Contributor Author

Chiefpatwal commented Oct 27, 2024

This issue also fails #6009

@siriak so clearly this is not my from my end ? besides how can i resolve this conflict...? any suggestions.

@siriak
Copy link
Copy Markdown
Member

siriak commented Oct 27, 2024

The infer check was fix, update your branch with the latest main and it should be fixed

@Chiefpatwal
Copy link
Copy Markdown
Contributor Author

Chiefpatwal commented Oct 27, 2024 •
edited
Loading

Conflicts have been...already added test you may merge now.

@Chiefpatwal
Copy link
Copy Markdown
Contributor Author

Chiefpatwal commented Oct 27, 2024

done @siriak

siriak
siriak approved these changes Oct 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit bca8d0e into TheAlgorithms:master Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chiefpatwal @codecov-commenter @siriak