Add tests for NodeStack and rework#6009
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6009 +/- ##
============================================
- Coverage 72.37% 72.36% -0.01%
+ Complexity 4981 4979 -2
============================================
Files 652 652
Lines 17569 17564 -5
Branches 3385 3384 -1
============================================
- Hits 12716 12711 -5
Misses 4373 4373
Partials 480 480 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/main/java/com/thealgorithms/datastructures/stacks/NodeStack.java
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
siriak
left a comment
There was a problem hiding this comment.
Everything except print looks good
src/main/java/com/thealgorithms/datastructures/stacks/NodeStack.java
Outdated
Show resolved
Hide resolved
|
I cannot solve this PR because during a CI/CD pipeline run with Infer, a potential Null Dereference was detected in the BinaryTreeTest class. src/test/java/com/thealgorithms/datastructures/trees/BinaryTreeTest.java:38: error: Null Dereference(NULLPTR_DEREFERENCE) To solve the build problem, if I wish, I can apply a temporary fix to prevent the test from failing on the BinaryTreeTest class (e.g., by adding a null check in getRoot()) @siriak Let me know how to proceed |
|
Hmm, that's odd. Could you try to fix the issue here or in a separate PR? |
Hey @lorduke22, I’m facing the same conflict issue due to the failing Infer run check. I’m stuck and could use some guidance if you have any insights on resolving it. |
|
@siriak I should have solved the problem in this PR. Feel free to add the following control to your code |
siriak
left a comment
There was a problem hiding this comment.
Great, thanks for fixing this!

clang-format -i --style=file path/to/your/file.java