Skip to content

Add function documentation in Sudoku.java#5532

Merged
alxkm merged 31 commits into
TheAlgorithms:masterfrom
Hardvan:sudoku_improvement
Oct 4, 2024
Merged

Add function documentation in Sudoku.java#5532
alxkm merged 31 commits into
TheAlgorithms:masterfrom
Hardvan:sudoku_improvement

Conversation

@Hardvan

@Hardvan Hardvan commented Oct 3, 2024

Copy link
Copy Markdown
Contributor
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@Hardvan Hardvan changed the title Add function documentation and parameterized tests to Sudoku.java Add function documentation in Sudoku.java Oct 3, 2024
@codecov-commenter

codecov-commenter commented Oct 3, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.97%. Comparing base (be8df21) to head (4c80e7f).
⚠️ Report is 823 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5532      +/-   ##
============================================
+ Coverage     52.95%   52.97%   +0.01%     
- Complexity     3309     3310       +1     
============================================
  Files           529      529              
  Lines         15343    15343              
  Branches       2925     2925              
============================================
+ Hits           8125     8128       +3     
+ Misses         6882     6881       -1     
+ Partials        336      334       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hardvan Hardvan marked this pull request as ready for review October 3, 2024 04:46
@Hardvan Hardvan requested a review from siriak as a code owner October 3, 2024 04:46
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java Outdated
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java Outdated
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java Outdated
@Hardvan Hardvan requested a review from alxkm October 3, 2024 14:14
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java Outdated
Comment thread src/main/java/com/thealgorithms/others/Sudoku.java
@Hardvan Hardvan requested a review from alxkm October 4, 2024 14:44
@Hardvan

Hardvan commented Oct 4, 2024

Copy link
Copy Markdown
Contributor Author

I have changed the class and function documentations to reflect the aforementioned suggested changes.

@alxkm alxkm merged commit 66ee59c into TheAlgorithms:master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants