Created DiffieHellman.java and MonoAlphabetic.java #5508
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5508 +/- ##
============================================
- Coverage 66.98% 66.97% -0.01%
- Complexity 4523 4530 +7
============================================
Files 613 615 +2
Lines 16990 17019 +29
Branches 3282 3286 +4
============================================
+ Hits 11380 11398 +18
- Misses 5160 5166 +6
- Partials 450 455 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vil02
requested changes
Oct 2, 2024
vil02
left a comment
Member
There was a problem hiding this comment.
Please remove the main methods and add proper junit tests. Prefer ParameterizedTests.
Member
|
@vil02 please review |
Contributor
Author
|
Hi @vil02, kindly review the changed code. |
Contributor
Author
|
Hello @vil02 @siriak @alxkm @BamaCharanChhandogi @yanglbme |
siriak
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Diffie-Hellman Key Exchange and MonoAlphabetic Cipher algorithms.
Key Changes:
Diffie-Hellman Key Exchange:
DiffieHellman.javaunder theciphersdirectory.MonoAlphabetic Cipher:
MonoAlphabetic.javaunder theciphersdirectory.Both algorithms are utility classes, with private constructors to prevent instantiation and static methods to handle their respective functionalities.
clang-format -i --style=file path/to/your/file.java