Adds Longest Arithmetic Subsequence Implementation#5501
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5501 +/- ##
============================================
+ Coverage 52.93% 52.98% +0.05%
- Complexity 3306 3311 +5
============================================
Files 528 529 +1
Lines 15330 15343 +13
Branches 2922 2925 +3
============================================
+ Hits 8115 8130 +15
+ Misses 6881 6880 -1
+ Partials 334 333 -1 ☔ View full report in Codecov by Sentry. |
tejaswi0910
requested review from
BamaCharanChhandogi,
alxkm,
siriak,
vil02 and
yanglbme
as code owners
vil02
requested changes
Oct 2, 2024
vil02
left a comment
vil02
left a comment
Member
There was a problem hiding this comment.
Please remove the main method and add proper junit tests instead. Prefer ParameterizedTests.
Contributor
Author
sure @vil02 , removed the main function and added tests! |
vil02
requested changes
Oct 2, 2024
vil02
requested changes
Oct 2, 2024
…hmeticSubsequence.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
…hmeticSubsequence.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
6 tasks
vil02
requested changes
Oct 2, 2024
…hmeticSubsequence.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
…hmeticSubsequence.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
…hmeticSubsequenceTest.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
…hmeticSubsequence.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
vil02
approved these changes
Oct 3, 2024
Member
|
Just a small tip: if you want to modify the last commit, you can use Happy hacktoberfest! |
Contributor
Author
Thanks @vil02, didn't know this....will surely use this in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Longest Arithmetic Subsequence algorithm. The algorithm identifies the length of the longest arithmetic subsequence from a given array of integers, where a subsequence is defined as arithmetic if the differences between consecutive elements are the same.
Key Changes:
Added LongestArithmeticSubsequence.java under the dynamicprogramming directory.
The implementation uses dynamic programming with a HashMap to store the differences between elements and keep track of subsequences efficiently.
clang-format -i --style=file path/to/your/file.java