refactor: cleanup PigeonholeSort#5298
Merged
vil02 merged 6 commits intoTheAlgorithms:masterfrom Jul 25, 2024
alxkm:refactor/pigeonhole_sort
Merged
refactor: cleanup PigeonholeSort#5298vil02 merged 6 commits intoTheAlgorithms:masterfrom alxkm:refactor/pigeonhole_sort
PigeonholeSort#5298vil02 merged 6 commits intoTheAlgorithms:masterfrom
alxkm:refactor/pigeonhole_sort
Conversation
alxkm
requested review from
BamaCharanChhandogi,
vil02 and
yanglbme
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5298 +/- ##
============================================
+ Coverage 41.24% 41.42% +0.18%
- Complexity 2539 2552 +13
============================================
Files 520 520
Lines 15449 15447 -2
Branches 2953 2950 -3
============================================
+ Hits 6372 6399 +27
+ Misses 8782 8754 -28
+ Partials 295 294 -1 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
Jul 25, 2024
… more test for negative numbers
vil02
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missed test.
Improve code structure, this should add more readability.
Replaced
ArrayList<Integer>[] pigeonHole = new ArrayList[numOfPigeonholes];withList<List<Integer>> pigeonHoles = new ArrayList<>(maxElement + 1);.Because such constructions in Java is generally not considered good practice.
clang-format -i --style=file path/to/your/file.java