Skip to content

style: include OI_OPTIONAL_ISSUES_USES_IMMEDIATE_EXECUTION #5274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siriak merged 1 commit into from
Jul 3, 2024
Merged

style: include OI_OPTIONAL_ISSUES_USES_IMMEDIATE_EXECUTION #5274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,6 @@
<Match>
<Bug pattern="BL_BURYING_LOGIC" />
</Match>
<Match>
<Bug pattern="OI_OPTIONAL_ISSUES_USES_IMMEDIATE_EXECUTION" />
</Match>
<Match>
<Bug pattern="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS" />
</Match>
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/thealgorithms/searches/BreadthFirstSearchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void testSearchRoot() {

// check value
Optional<Node<String>> value = bfs.search(root, expectedValue);
assertEquals(expectedValue, value.orElse(new Node<>("")).getValue());
assertEquals(expectedValue, value.orElseGet(() -> new Node<>("")).getValue());

// check path
assertArrayEquals(expectedPath.toArray(), bfs.getVisited().toArray());
Expand All @@ -65,7 +65,7 @@ public void testSearchF() {
List<String> expectedPath = List.of("A", "B", "C", "D", "E", "F");

// check value
Optional<Node<String>> value = Optional.of(bfs.search(root, expectedValue).orElse(new Node<>(null)));
Optional<Node<String>> value = Optional.of(bfs.search(root, expectedValue).orElseGet(() -> new Node<>(null)));
assertEquals(expectedValue, value.get().getValue());

// check path
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/thealgorithms/searches/DepthFirstSearchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public void testSearchRoot() {

// check value
Optional<Node<Integer>> value = dfs.recursiveSearch(root, expectedValue);
assertEquals(expectedValue, value.orElse(new Node<>(null)).getValue());
assertEquals(expectedValue, value.orElseGet(() -> new Node<>(null)).getValue());

// check path
assertArrayEquals(expectedPath.toArray(), dfs.getVisited().toArray());
Expand All @@ -67,7 +67,7 @@ public void testSearch4() {

// check value
Optional<Node<Integer>> value = dfs.recursiveSearch(root, expectedValue);
assertEquals(expectedValue, value.orElse(new Node<>(null)).getValue());
assertEquals(expectedValue, value.orElseGet(() -> new Node<>(null)).getValue());

// check path
assertArrayEquals(expectedPath.toArray(), dfs.getVisited().toArray());
Expand Down