Repository navigation
Remove SetKthBit - #4991
Merged
Merged
Remove SetKthBit#4991
SetKthBit#4991Conversation
vil02
marked this pull request as ready for review
January 2, 2024 22:38
vil02
requested review from
BamaCharanChhandogi,
debasishbsws and
yanglbme
as code owners
January 2, 2024 22:38
vil02
force-pushed
the
remove_set_kth_bit
branch
from
January 3, 2024 18:17
4e8a161 to
1576b55
Compare
siriak
approved these changes
Jan 3, 2024
siriak
left a comment
siriak
left a comment
Member
There was a problem hiding this comment.
Good catch! I wonder if there's a way to make this class more discoverable because SetKthBit is what people are often looking for. And while on further inspection it's clear that SingleBitOperations must have SetKthBit inside, it's not found by simple search by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetKthBit.setKthBitis the same asSingleBitOperations.setBit, therefore I decided to removeSetKthBit. However, I suggest to keep tests cases ofSetKthBit.setKthBitinSingleBitOperationsTest.clang-format -i --style=file path/to/your/file.java