Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Jul 31, 2023

This PR:

  • adds tests for the class GenericRoot,
  • does some refactoring if it.

I do not know about the general policy here: should I use the existing methods from SumOfDigits?

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit ee23b6c into TheAlgorithms:master Aug 3, 2023
@vil02 vil02 deleted the add_tests_of_GenericRoot branch August 3, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants