style: format code and fix #4204#4212
Merged
yanglbme merged 1 commit intoTheAlgorithms:masterfrom Jun 9, 2023
acbin:dev
Merged
style: format code and fix #4204#4212yanglbme merged 1 commit intoTheAlgorithms:masterfrom acbin:dev
yanglbme merged 1 commit intoTheAlgorithms:masterfrom
acbin:dev
Conversation
Contributor
acbin
commented
Jun 9, 2023
acbin
commented
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
yanglbme
approved these changes
Jun 9, 2023
siriak
reviewed
Jun 9, 2023
Comment on lines
+60
to
+61
| public SimpleTreeNode(E data, SimpleTreeNode<E> parentNode, SimpleTreeNode<E> leftNode, | ||
| SimpleTreeNode<E> rightNode) { |
Member
There was a problem hiding this comment.
It's not formatted correctly, in my opinion. They should either all be on the same line, or all be on separate lines.
We really need to add an automatic linter in the build job to avoid breaking formatting in one place when fixing it in another.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.