Repository navigation
used to find the shorthest paths among all pairs of nodes in a graph, - #389
Closed
ayushnagar123 wants to merge 1 commit into
Closed
ayushnagar123 wants to merge 1 commit into
ayushnagar123 wants to merge 1 commit into
Conversation
Floyd-Warshall algorithm is a procedure, which is used to find the shorthest (longest) paths among all pairs of nodes in a graph, which does not contain any cycles of negative lenght. The main advantage of Floyd-Warshall algorithm is its simplicity.
christianbender
requested changes
Mar 29, 2018
christianbender
left a comment
christianbender
left a comment
There was a problem hiding this comment.
Good Work! I have some requests
|
|
||
|
|
||
| public class FloydWarshall | ||
|
|
There was a problem hiding this comment.
Remove unnecessary empty lines.
|
|
||
| { | ||
|
|
||
| adjacency_matrix[source][destination] = scan.nextInt(); |
There was a problem hiding this comment.
Spare the user for unnecessary inputs if the inputs will be overwrite.
|
|
||
| { | ||
|
|
||
| private int distancematrix[][]; |
There was a problem hiding this comment.
Naming conventions: Use camel case
For example distanceMatrix
|
|
||
| { | ||
|
|
||
| adjacency_matrix[source][destination] = 0; |
|
|
||
| { | ||
|
|
||
| distancematrix = new int[numberofvertices + 1][numberofvertices + 1]; |
There was a problem hiding this comment.
Please initialize the array 'distancematrix' with zeros. for safety.
christianbender
requested changes
Mar 29, 2018
|
|
||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Put in comments in your code. Makes the program readable for others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floyd-Warshall algorithm is a procedure, which is used to find the shorthest (longest) paths among all pairs of nodes in a graph, which does not contain any cycles of negative lenght. The main advantage of Floyd-Warshall algorithm is its simplicity.