Skip to content

Test case for vowels check - #3658

Merged
siriak merged 4 commits into
TheAlgorithms:masterfrom
harshalkh:patch-1
Oct 26, 2022
Merged

siriak merged 4 commits into
TheAlgorithms:masterfrom
harshalkh:patch-1

Conversation

@harshalkh

Copy link
Copy Markdown
Contributor

Fixes #3594

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@debasishbsws debasishbsws left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@harshalkh

Copy link
Copy Markdown
Contributor Author

@siriak @yanglbme can you review this ...

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
siriak merged commit 3aadb9d into TheAlgorithms:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need test cases for many of the Algorithms.

3 participants