Skip to content

Fixed error in Palindrome.java and gave semantic names to functions #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
debasishbsws merged 8 commits into from
Oct 27, 2022
Merged

Fixed error in Palindrome.java and gave semantic names to functions #3643

debasishbsws merged 8 commits into from
Oct 27, 2022

Conversation

@TaranjeetSinghKalsi
Copy link
Contributor

@TaranjeetSinghKalsi TaranjeetSinghKalsi commented Oct 23, 2022

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TaranjeetSinghKalsi
fixed error and changed functions names
920ed9c 
fixed error at line 57 and gave semantic names to functions with comments
@TaranjeetSinghKalsi
renamed functions
e20c21c 
renamed functions to match with original functions' names in the file
@TaranjeetSinghKalsi TaranjeetSinghKalsi changed the title fixed error and made gave names to functions with comments fixed error and gave semantic names to functions with comments Oct 24, 2022
@TaranjeetSinghKalsi TaranjeetSinghKalsi changed the title fixed error and gave semantic names to functions with comments Fixed error in Palindrome and gave semantic names to functions with comments Oct 24, 2022
@TaranjeetSinghKalsi TaranjeetSinghKalsi changed the title Fixed error in Palindrome and gave semantic names to functions with comments Fixed error in Palindrome.java and gave semantic names to functions Oct 25, 2022
debasishbsws
debasishbsws requested changes Oct 25, 2022
View reviewed changes
@TaranjeetSinghKalsi
Updated TestCases
579cbc3 
Updated TestCases and changed a function name
@TaranjeetSinghKalsi
Removed main() and changed function name
31fb434 
Removed main() and changed the function name from isPalindromeStringBuilder to isPalindrome
@TaranjeetSinghKalsi
fixed typo
e863f65
debasishbsws
debasishbsws approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@debasishbsws debasishbsws merged commit bd267bb into TheAlgorithms:master Oct 27, 2022
@TaranjeetSinghKalsi TaranjeetSinghKalsi deleted the patch-1 branch October 29, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@debasishbsws debasishbsws debasishbsws approved these changes

@siriak siriak Awaiting requested review from siriak

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TaranjeetSinghKalsi @debasishbsws