I added two algorithm related to matrix.#3364
Merged
siriak merged 11 commits intoTheAlgorithms:masterfrom Jan 14, 2023
Merged
Conversation
This algorithm is used to search a key from a sorted matrix.
This algorithm helps printing a matrix in spiral order.
siriak
requested changes
Jan 9, 2023
Member
siriak
left a comment
siriak
left a comment
There was a problem hiding this comment.
The code looks good, could you please add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)
Contributor
Author
|
Thank you for your reply. I'll try to add some test code as soon as possible.. |
siriak
reviewed
Jan 10, 2023
src/main/java/com/thealgorithms/searches/SearchInARowAndColWiseSortedMatrix.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/searches/TestSearchInARowAndColWiseSortedMatrix.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/searches/SearchInARowAndColWiseSortedMatrix.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/searches/SearchInARowAndColWiseSortedMatrix.java
Outdated
Show resolved
Hide resolved
siriak
requested changes
Jan 10, 2023
Member
siriak
left a comment
siriak
left a comment
There was a problem hiding this comment.
The search and its tests looks good. Could you make PrintAMatrixInSpiralOrder return what it intends to print as an array and add tests for that? Or just remove it and I can merge the search. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
References
Checklist: