Skip to content

Implement A5 Cipher#3292

Merged
siriak merged 4 commits into
TheAlgorithms:masterfrom
HHHMHA:a5
Sep 27, 2022
Merged

Implement A5 Cipher#3292
siriak merged 4 commits into
TheAlgorithms:masterfrom
HHHMHA:a5

Conversation

@HHHMHA

@HHHMHA HHHMHA commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

Added A5 Cipher Algorithm. with a demo and actual real time sound recording encryption.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove SoundRecorders, ApplicationProperties, WaveDataUtil (i.e., things not related to A5 cipher)

@HHHMHA

HHHMHA commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

@siriak Done

@HHHMHA HHHMHA requested a review from siriak September 26, 2022 09:15
@siriak siriak enabled auto-merge (squash) September 27, 2022 16:30

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit e4eb99f into TheAlgorithms:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants