Skip to content

Add Devcontainer Support and Fixing Testcases for LinkListSort - #3156

Merged
siriak merged 8 commits into
TheAlgorithms:masterfrom
arindam89:master
Jun 24, 2022
Merged

siriak merged 8 commits into
TheAlgorithms:masterfrom
arindam89:master

Conversation

@arindam89

@arindam89 arindam89 commented Jun 21, 2022 •

Copy link
Copy Markdown
Contributor

Add Devcontainer Support and Fixing Testcases for LinkListSort

  • Added Remote container Devleopment support now, this can be opened with remote dev containers directly without any setup.
  • Fix filename Link_List_test and fixed two testcases within it.
  • Changed the filename so that it gets run with mvn test

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

@arindam89

Copy link
Copy Markdown
Contributor Author

I am not getting what's the issue here for the build. I haven't touched

@arindam89

Copy link
Copy Markdown
Contributor Author

Fixed a small bug on .github workflow as well.

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
siriak merged commit 0d97d0b into TheAlgorithms:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants