Skip to content

Fixes: #2724 Add description for Sieve of Eratosthenes algorithm. Refactor a little bit#2725

Merged
siriak merged 2 commits into
TheAlgorithms:masterfrom
Boiarshinov:issue-2724_add_description_to_sieve_of_eratosthenes
Oct 27, 2021
Merged

Fixes: #2724 Add description for Sieve of Eratosthenes algorithm. Refactor a little bit#2725
siriak merged 2 commits into
TheAlgorithms:masterfrom
Boiarshinov:issue-2724_add_description_to_sieve_of_eratosthenes

Conversation

@Boiarshinov

@Boiarshinov Boiarshinov commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

Changes:

  • add description of algorithm

  • add link to wiki

  • delete @author tag cause git blame remembers everyone 😄

  • change algo method - now it's not print result but return it

  • add enum instead of magic numbers

  • add description of algorithm steps

  • extend example with description

  • Fix a bug or typo in an existing algorithm?

  • Add an algorithm?

  • Documentation change?

References

related issue: #2724

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@siriak siriak requested a review from yanglbme as a code owner October 27, 2021 19:00
@siriak siriak merged commit b2de5c7 into TheAlgorithms:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants