Skip to content

Fixes: #2716 Incorrect file extension and other improvements#2717

Merged
siriak merged 5 commits into
TheAlgorithms:masterfrom
shivamshrey:master
Oct 27, 2021
Merged

Fixes: #2716 Incorrect file extension and other improvements#2717
siriak merged 5 commits into
TheAlgorithms:masterfrom
shivamshrey:master

Conversation

@shivamshrey

@shivamshrey shivamshrey commented Oct 23, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@shivamshrey shivamshrey requested a review from siriak as a code owner October 23, 2021 19:13
@shivamshrey

shivamshrey commented Oct 24, 2021

Copy link
Copy Markdown
Contributor Author

Fixes #2716

@siriak siriak requested a review from yanglbme as a code owner October 27, 2021 18:54
siriak
siriak approved these changes Oct 27, 2021
View reviewed changes

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siriak siriak merged commit 9b90628 into TheAlgorithms:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivamshrey @siriak