Repository navigation
Conversation
Author
|
@AnupKumarPanwar please review PR!! and let me know suggestions! |
Closed
varunu28
suggested changes
Nov 9, 2017
varunu28
left a comment
Contributor
There was a problem hiding this comment.
- Kindly keep a separate function for the sorting algorithm and use the main method only for testing the algorithm
- Convert the algorithm to its generic version
Author
|
@varunu28 I understand your first point. But didn't get second point. Do you want me to convert it into generic in terms of data type or in terms of range of input? |
Contributor
|
@YJDave Your algorithm should sort the arrays of all data types. Be it string array or an integer array. Please check Insertion Sort for reference |
Author
|
Okay!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96