Skip to content

Fixes: #2620: Affine Cipher#2628

Closed
kumanoit wants to merge 2 commits into
TheAlgorithms:masterfrom
kumanoit:jira/affine
Closed

Fixes: #2620: Affine Cipher#2628
kumanoit wants to merge 2 commits into
TheAlgorithms:masterfrom
kumanoit:jira/affine

Conversation

@kumanoit

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@kumanoit kumanoit requested a review from siriak as a code owner October 15, 2021 07:22
@kumanoit kumanoit changed the title Fixes: #2620: Affine Cipher Fixes: #2628: Affine Cipher Oct 15, 2021
@kumanoit kumanoit changed the title Fixes: #2628: Affine Cipher Fixes: #2620: Affine Cipher Oct 15, 2021
@siriak

siriak commented Oct 22, 2021

Copy link
Copy Markdown
Member

We already have it implemented here https://github.com/TheAlgorithms/Java/blob/master/Ciphers/AffineCipher.java, feel free to fix the existing implementation if there are any problems, thanks!

@siriak siriak closed this Oct 22, 2021
@kumanoit

Copy link
Copy Markdown
Contributor Author

oh... The one which is already there(#2668 ) was committed after I raised this(#2620).

@siriak

siriak commented Oct 22, 2021

Copy link
Copy Markdown
Member

That is unfortunate, lately many people open PRs, so it's hard to keep track of everything

@kumanoit

Copy link
Copy Markdown
Contributor Author

I totally understand. No worries :)

@kumanoit kumanoit deleted the jira/affine branch October 23, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants