Skip to content

Now I have added .gitignore file in the issue of #2264 #2330

Merged
siriak merged 2 commits into
TheAlgorithms:masterfrom
Rajat-Jain29:master
Sep 17, 2021
Merged

Now I have added .gitignore file in the issue of #2264 #2330
siriak merged 2 commits into
TheAlgorithms:masterfrom
Rajat-Jain29:master

Conversation

@Rajat-Jain29

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Rajat-Jain29

Copy link
Copy Markdown
Contributor Author

@siriak Now have a look into it. I have added a .gitignore file.

@siriak

siriak commented Sep 17, 2021

Copy link
Copy Markdown
Member

Why have you added .gitignore? Please remove it. Apart from that, looks good

@Rajat-Jain29

Copy link
Copy Markdown
Contributor Author

@siriak Now it's fine?

@siriak siriak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@siriak siriak merged commit e6fb81d into TheAlgorithms:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants