Skip to content

Optimize method flip in SortUtils #1246 #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StepfenShawn merged 2 commits into from
May 6, 2020
Merged

Optimize method flip in SortUtils #1246 #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f2661
Solve the Optimize method flip in SortUtils #1246
Mar 17, 2020
7b1c328
fix a bug #1250
Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/sorts/CycleSort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public <T extends Comparable<T>> T[] sort(T[] arr) {
int count = 0;

// Traverse array and put the elements on their respective right places
for (int i = 0; i < n - 2; i++) {
for (int i = 0; i < n - 1; i++) {

// Initialize item as the starting point
T item = arr[i];
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/sorts/SortUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static <T extends Comparable<T>> boolean less(T v, T w) {
* @param right is a right flip border of the array
*/
static <T extends Comparable<T>> void flip(T[] array, int left, int right) {
while (left <= right) {
while (left < right) {
swap(array, left++, right--);
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/dataStructures/StackTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void testPeekWithElements() {
myStack.push(30);
myStack.push(40);

Assertions.assertEquals(40, myStack.peek());
Assertions.assertEquals(40, (int) myStack.peek());
}

@Test
Expand All @@ -57,7 +57,7 @@ void testPopWithElements() {
myStack.push(40);
myStack.push(50);

Assertions.assertEquals(50, myStack.pop());
Assertions.assertEquals(50, (int) myStack.pop());

}

Expand Down
3 changes: 3 additions & 0 deletions src/test/java/com/sorts/CycleSortTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@ void cycleSortIntegerTest() {
String[] sortedStr = new String[]{"Alan", "David", "Dennis", "Edward", "Ken", "Linus", "Robert"};
Assertions.assertArrayEquals(sortedStr, cycleSort.sort(unsortedStr));

Integer[] unsortedShortInt = new Integer[]{29, 11};
Integer[] sortedShortInt = new Integer[]{11, 29};
Assertions.assertArrayEquals(sortedShortInt, cycleSort.sort(unsortedShortInt));
}
}