You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to contribute it. I see that you have no shell sort algorithm for Java. I would take that one first. Than later I would continue with few mores, if that is ok.
@mpokryva I mistakenly thought you were talking to me. And not asking for yourself. Anyway, you can grab that one, and I hope that @dynamitechetan needs shellsort, so I do that one.
@dynamitechetan@AnupKumarPanwar Would be continue to add more algorithms to this as a part of hacktoberfest
PRs would be maily in Data Structures and other domain
Please look over pull requests before merging because I noticed the most recent one won't even compile properly and I'm assuming that a lot of people will make PRs soon because of Hacktoberfest (myself included). For example, in PR #101 there are many errors.
Can't compile because there is no type for len_a and len_b
Can't compile because calculate_distance is a non-static method
One of the loops will go on forever because it's declared as for(int j = 0; i < len_b; j++) and i is not getting updated within the loop.
Reacted by Varun Upadhyay, Sam Buchmiller and Andrii Lysenko
@rei2hu@dynamitechetan@AnupKumarPanwar
Also the PRs should be monitored correctly to check for coding style and if an addition to the repo is actually an algorithm or just a solution of an interview question. The long term goal should be to make this repo as a one stop solution for Java algorithms rather than a repository with bunch of random interview problems.
@dynamitechetan@varunu28@rei2hu
I think we should create a repo that contains simple English explanation of the algorithms with example and a link to their implementation in different programming languages.
@AnupKumarPanwar I am relatively late here so I thought I directly ask you. Whats next in your priority list. i ll address it. I love writing algorithms.
I have just opened a pull request in which I add the Floyd Warshall graph algorithm to find shortest paths between every pair of vertices. If you please review me.. (:
Hey, a friend of mine and I would write the Hopcroft-Karp algorithm with the amount of maximal cardinal matchings as output and - if we're able to implement it - extend it later to give out the exact matchings.
Hi there, user Febaug has tipped me off about this project and I'd like to contribute as well. I've seen that you have a subdirectory for crypto algorithms, but you're still missing an implementation of the Advanced Encryption Standard. I'd love to build that for you unless you see a problem with that.
Activity
dhinske commentedon Sep 28, 2017
would you be interested in some Set-implementations or maybe Bag? didnt see it in your repo :)
dpunosevac commentedon Sep 28, 2017
I would like to contribute it. I see that you have no shell sort algorithm for Java. I would take that one first. Than later I would continue with few mores, if that is ok.
mpokryva commentedon Sep 28, 2017
Would you be interested in a level-order tree traversal?
dynamitechetan commentedon Sep 28, 2017
Thanks. @mpokryva
mpokryva commentedon Sep 28, 2017
Ok, I will take that then. Or, if you want, @dpunosevac , you can do that, and I can do some bit algorithms, as I don't see any of those.
dpunosevac commentedon Sep 28, 2017
@mpokryva I mistakenly thought you were talking to me. And not asking for yourself. Anyway, you can grab that one, and I hope that @dynamitechetan needs shellsort, so I do that one.
mpokryva commentedon Sep 28, 2017
Ok, sounds good! Sorry for the misunderstanding :)
varunu28 commentedon Sep 28, 2017
@dynamitechetan @AnupKumarPanwar Would be continue to add more algorithms to this as a part of hacktoberfest
PRs would be maily in Data Structures and other domain
rei2hu commentedon Sep 28, 2017
Please look over pull requests before merging because I noticed the most recent one won't even compile properly and I'm assuming that a lot of people will make PRs soon because of Hacktoberfest (myself included). For example, in PR #101 there are many errors.
Can't compile because there is no type for
len_aandlen_bCan't compile because
calculate_distanceis a non-static methodOne of the loops will go on forever because it's declared as
for(int j = 0; i < len_b; j++)andiis not getting updated within the loop.varunu28 commentedon Sep 28, 2017
@rei2hu @dynamitechetan @AnupKumarPanwar
Also the PRs should be monitored correctly to check for coding style and if an addition to the repo is actually an algorithm or just a solution of an interview question. The long term goal should be to make this repo as a one stop solution for Java algorithms rather than a repository with bunch of random interview problems.
AnupKumarPanwar commentedon Sep 29, 2017
@dynamitechetan @varunu28 @rei2hu
I think we should create a repo that contains simple English explanation of the algorithms with example and a link to their implementation in different programming languages.
praveenkannan commentedon Sep 29, 2017
@AnupKumarPanwar I am relatively late here so I thought I directly ask you. Whats next in your priority list. i ll address it. I love writing algorithms.
AnupKumarPanwar commentedon Sep 30, 2017
@praveenkannan I would like you to contribute on
https://github.com/TheAlgorithms/Algorithms-Explainations
praveenkannan commentedon Oct 1, 2017
@AnupKumarPanwar assign that to me. I am starting to work on it now.
37 remaining items
YJDave commentedon Oct 25, 2017
@AnupKumarPanwar Add algorithm for Bucket Sort. Let me know if any changes are required :)
Closes TheAlgorithms#96
Dynamic Array
italo-batista commentedon Oct 31, 2017
I have just opened a pull request in which I add the Floyd Warshall graph algorithm to find shortest paths between every pair of vertices. If you please review me.. (:
italo-batista commentedon Oct 31, 2017
I also opened a pull request to add the sorting algorithm QuickSortMedianOfThree. 😁
zhexuany commentedon Oct 31, 2017
add a algo for coin change https://github.com/TheAlgorithms/Java/pulls
italo-batista commentedon Oct 31, 2017
Pull Request to add Bellman-Ford graph algorithm to find shortest path from one vertex to all. 😃
Merge pull request #153 from gagndeepp/patch-2
Febaug commentedon Nov 12, 2017
Hey, a friend of mine and I would write the Hopcroft-Karp algorithm with the amount of maximal cardinal matchings as output and - if we're able to implement it - extend it later to give out the exact matchings.
Phil-Schmidt commentedon Nov 13, 2017
Hi there, user Febaug has tipped me off about this project and I'd like to contribute as well. I've seen that you have a subdirectory for crypto algorithms, but you're still missing an implementation of the Advanced Encryption Standard. I'd love to build that for you unless you see a problem with that.
YooSeonjae commentedon Dec 17, 2017
Add a circular queue or ring wait, a data structure that uses a single fixed-size buffer just like an end-to-end connection
#322
YooSeonjae commentedon Dec 17, 2017
One of the greedy algorithms, Scheduling to Minimize Lateness
#309
anthonycampbell commentedon Apr 21, 2018
Could I add a skiplist implementation?
RishiPrakash commentedon May 2, 2018
I have added pullRequest , please review and merge.