添加强名称与源链接 / Add Strong Name & SourceLink #305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lillo42
changed the title
Author
|
@zqfan can you review this PR? |
Member
|
is it enough or need to do more? @lillo42 |
Author
|
No, that is not enough, if you look at the generated dll (https://nuget.info/packages/TencentCloudSDK.Ccc/3.0.1227 or https://nuget.info/packages/TencentCloudSDK.Ccc/3.0.1227)you can see its not mark with strong name. I think it missing the key (.snk) and/or the property DotnetKeyFile doesn't have the correct value |
@zqfan Hi, I think you need these two lines to enable StrongName. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72