Added support for Add-Ons and json content type#11
Conversation
mrasic-telesign
requested review from
djuricko,
hmorales,
jarradsl,
jkrstic,
vdamjanic and
vdjordjevic
| return self.post(PHONEID_RESOURCE.format(phone_number=phone_number), | ||
| **params) | ||
|
|
||
| def _execute(self, method_function, method_name, resource, **params): |
There was a problem hiding this comment.
Would prefer to see this incorporated into the base class RestClient function so that other endpoints can take advantage of it. If not, you need test coverage for this implementation.
telesign/phoneid.py
Outdated
| return response | ||
|
|
||
| @staticmethod | ||
| def generate_telesign_headers(customer_id, api_key, method_name, resource, json_fields, date_rfc2616=None, |
There was a problem hiding this comment.
Same here. The point of the staticmethod is that customers can extract this in entirety and use it in their own application if they would prefer not to use the SDK. Would prefer to see these changes incorporated into the base class RestClient function. If not, you need test coverage for this implementation.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 64.58% 56.84% -7.74%
==========================================
Files 8 7 -1
Lines 144 146 +2
Branches 9 11 +2
==========================================
- Hits 93 83 -10
- Misses 49 60 +11
- Partials 2 3 +1
Continue to review full report at Codecov.
|
release-at-telesign
deleted the
feature/TSMD-8502_Python_PhoneID_SDK_change
branch
4 participants
No description provided.