Migrated the Telesign Java Client to Maven#10
Closed
dleblanc wants to merge 2 commits intoTeleSign:masterfrom
dleblanc:master
Closed
Migrated the Telesign Java Client to Maven#10dleblanc wants to merge 2 commits intoTeleSign:masterfrom dleblanc:master
dleblanc wants to merge 2 commits intoTeleSign:masterfrom
dleblanc:master
Conversation
Moved the tests to be integration tests, run with Failsafe (not verified, I don't have an account). Made this an OSGi bundle as well.
Please don't use this project! It's not worth your time.
Author
|
After looking at the code, I've decided to withdraw this pull request. Telesign ought to look at improving the quality of this SDK, this is surprisingly bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I've converted your Telesign Java SDK to be built by Maven, and also to be an OSGi bundle (that
also works fine as a normal Jar).
You might be interested in this change.