Conversation
Added the new lib for commens codec. Added support for sha256 and nonce token. Removed the phonUtil class to allow phone number validation to happen on the server side. Added tests for the new sha and nonce functionality.
There was a problem hiding this comment.
Let's remove the CustomerID and Secret QA values. Replace with place holders below and a comment asking them to contact TeleSign for credentials.
CUSTOMER_ID = "YOUR CUSTOMER_ID HERE"
SECRET_KEY = "YOUR SECRET_KEY HERE"
There was a problem hiding this comment.
I thought it was odd that this was in the repo to begin with as I was pretty sure I had pulled it out.
I will get this out and submit a new pull request today.
-jW
From: hmorales notifications@github.com
To: TeleSign/java_telesign java_telesign@noreply.github.com
Cc: jweatherford johnweatherford@rocketmail.com
Sent: Monday, March 11, 2013 9:48 AM
Subject: Re: [java_telesign] Re: Email request 2/28/13 (#1)
In test/com/telesign/TeleSignRequestTest.java:
@@ -18,6 +21,10 @@
- Author: jweatherford
*/
public class TeleSignRequestTest {- public final String CUSTOMER_ID = "440813A2-1F7E-11E1-B760-000000000000";
Let's remove the CustomerID and Secret QA values. Replace with place holders below and a comment asking them to contact TeleSign for credentials.
CUSTOMER_ID = "YOUR CUSTOMER_ID HERE"
SECRET_KEY = "YOUR SECRET_KEY HERE"
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Yes, we have disabled that account for security reasons. Going forward we want to read the credentials from a properties file (only for the unit tests) then add the *.properties to the gitignore file. This way anyone else contributing will not accidentally add their keys to the repo. Would you be able to do this?
There was a problem hiding this comment.
Good idea! I can do this.
Message sent via my mobile phone. Please excuse minor typos and message brevity.
On Mar 11, 2013, at 11:07 AM, hmorales notifications@github.com wrote:
In test/com/telesign/TeleSignRequestTest.java:
@@ -18,6 +21,10 @@
Author: jweatherford
*/
public class TeleSignRequestTest {
- public final String CUSTOMER_ID = "440813A2-1F7E-11E1-B760-000000000000";
Yes, we have disabled that account for security reasons. Going forward we want to read the credentials from a properties file (only for the unit tests) then add the *.properties to the gitignore file. This way anyone else contributing will not accidentally add their keys to the repo. Would you be able to do this?—
Reply to this email directly or view it on GitHub.
Create a properties file for the tests. Updated the .gitignore. Removed the PhoneUtil files that were mistakenly left
Conflicts: test/com/telesign/PhoneIdTest.java test/com/telesign/VerifyTest.java
2 participants
Added the new lib for commens codec. Added support for
sha256 and nonce token. Removed the phonUtil class to allow
phone number validation to happen on the server side. Added
tests for the new sha and nonce functionality.