Skip to content

Updated Docs - #1

Merged
TechnoBlogger14o3 merged 1 commit into
TechnoBlogger14o3:masterfrom
KaranGRohit:master
Oct 15, 2020
Merged

TechnoBlogger14o3 merged 1 commit into
TechnoBlogger14o3:masterfrom
KaranGRohit:master

Conversation

@KaranGRohit

Copy link
Copy Markdown
Contributor

No description provided.

@TechnoBlogger14o3 TechnoBlogger14o3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro, even if I merge, HactoberFest will put this for 14 Days Review, and if they think its a valid PR then only it will be counted.
So, my suggestion, write 1-2 programs, add new folder and push it. I'll Merge. Even this one I'm going to merge. Fingers Crossed.

@keikoro

keikoro commented Oct 17, 2020

Copy link
Copy Markdown

@TechnoBlogger14o3 I don't understand why you're even accepting this. He's already getting his PRs labelled as invalid by other maintainers because they are nonsensical, hopefully DO will pay attention.

@TechnoBlogger14o3

Copy link
Copy Markdown
Owner

@keikoro Thanks for putting this, I already told him, even if I merge, hacktober team will make it as invalid in its Review Period.

@keikoro

keikoro commented Oct 20, 2020

Copy link
Copy Markdown

@TechnoBlogger14o3 I think you are misunderstanding how this works. No-one goes and checks if the tens of thousands of PRs that are submitted by people participating are valid. It's done in an automated way, and you approved the PR both by labelling it as accepted and by merging it.

@TechnoBlogger14o3

Copy link
Copy Markdown
Owner

@keikoro will keep in mind from next time.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants