⚡ Bolt: Remove unnecessary Token cloning in parser - #9
Conversation
Changed the return type of `advance()` and `previous()` in the parser from `&Token` to `&'a Token`, tying the returned reference to the underlying token slice rather than the mutable `self` borrow. This satisfies the borrow checker and allows the removal of expensive `Token` `.clone()` calls throughout `expressions.rs` and `statements.rs`. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Changed the return type of `advance()` and `previous()` in the parser from `&Token` to `&'a Token`, tying the returned reference to the underlying token slice rather than the mutable `self` borrow. This satisfies the borrow checker and allows the removal of expensive `Token` `.clone()` calls throughout `expressions.rs` and `statements.rs`. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
1 participant
💡 What: Refactored lifetimes in the parser's
advanceandpreviousmethods and removed.clone()calls on tokens.🎯 Why: Methods were returning a reference tied to
&mut self. To call other methods onselfwhile holding a token, the token had to be cloned, causing unnecessary allocations. By tying the lifetime to the token slice (&'a Token), we bypass the borrow checker conflict.📊 Impact: Eliminates unnecessary memory allocations and copying for every token advanced or peeked during expression and statement parsing.
🔬 Measurement: Verified via
cargo test -p techscript_parserandcargo bench -p techscript_parser. No functional regressions.PR created automatically by Jules for task 9269391063391972267 started by @Tcode-Motion