Skip to content

refactor(eslint-plugin-query): remove the 'eslint < 8.37.0' fallbacks for 'sourceCode' and 'getScope' since the peer range starts at 8.57.0 - #12325

Open
sukvvon wants to merge 2 commits into
mainfrom
refactor/eslint-plugin-query-remove-old-eslint-fallbacks
Open

refactor(eslint-plugin-query): remove the 'eslint < 8.37.0' fallbacks for 'sourceCode' and 'getScope' since the peer range starts at 8.57.0#12325
sukvvon wants to merge 2 commits into
mainfrom
refactor/eslint-plugin-query-remove-old-eslint-fallbacks

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

🎯 Changes

stable-query-client and ASTUtils.getReferencedExpressionByIdentifier kept fallbacks for ESLint < 8.37.0 (context.getSourceCode() and context.getScope()), each behind an oxlint-disable-next-line typescript/no-unnecessary-condition comment. The eslint peer range starts at 8.57.0, where context.sourceCode and sourceCode.getScope() always exist, so the fallbacks never run. The other rules in this package already use context.sourceCode directly.

Use context.sourceCode and context.sourceCode.getScope(node) directly, and remove the fallbacks with their comments.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Compatibility
    • The query ESLint plugin now relies on newer ESLint source-code APIs. Support for older ESLint APIs has been removed, so ensure your ESLint version provides these APIs when using the plugin.

@sukvvon
refactor(eslint-plugin-query): remove the 'eslint < 8.37.0' fallbacks…
4760f04 
… for 'sourceCode' and 'getScope' since the peer range starts at 8.57.0
@sukvvon sukvvon self-assigned this Oct 25, 2026
@changeset-bot

changeset-bot Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6cd4504

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 6cd4504

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 7s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-25 12:16:20 UTC

@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 19 bumped as dependents.

🟨 Minor bumps

Package Version Reason
@tanstack/angular-query-experimental 5.104.5 → 5.105.0 Changeset
@tanstack/solid-query-devtools 5.104.5 → 5.105.0 Changeset
@tanstack/vue-query 5.104.5 → 5.105.0 Changeset
@tanstack/eslint-plugin-query 5.104.5 → 5.105.0 Dependent
@tanstack/preact-query 5.104.5 → 5.105.0 Dependent
@tanstack/preact-query-devtools 5.104.5 → 5.105.0 Dependent
@tanstack/preact-query-persist-client 5.104.5 → 5.105.0 Dependent
@tanstack/query-async-storage-persister 5.104.5 → 5.105.0 Dependent
@tanstack/query-broadcast-client-experimental 5.104.5 → 5.105.0 Dependent
@tanstack/query-core 5.104.5 → 5.105.0 Dependent
@tanstack/query-devtools 5.104.5 → 5.105.0 Dependent
@tanstack/query-persist-client-core 5.104.5 → 5.105.0 Dependent
@tanstack/query-sync-storage-persister 5.104.5 → 5.105.0 Dependent
@tanstack/react-query 5.104.5 → 5.105.0 Dependent
@tanstack/react-query-devtools 5.104.5 → 5.105.0 Dependent
@tanstack/react-query-next-experimental 5.104.5 → 5.105.0 Dependent
@tanstack/react-query-persist-client 5.104.5 → 5.105.0 Dependent
@tanstack/solid-query 5.104.5 → 5.105.0 Dependent
@tanstack/solid-query-persist-client 5.104.5 → 5.105.0 Dependent

🟩 Patch bumps

Package Version Reason
@tanstack/svelte-query-devtools 6.3.5 → 6.3.6 Changeset
@tanstack/vue-query-devtools 6.3.5 → 6.3.6 Changeset
@tanstack/lit-query 0.2.30 → 0.2.31 Dependent
@tanstack/svelte-query 6.3.5 → 6.3.6 Dependent
@tanstack/svelte-query-persist-client 6.3.5 → 6.3.6 Dependent

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4760f04 and 6cd4504.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between faa41e9 and 4760f04.

Files selected for processing: 2
  • packages/eslint-plugin-query/src/rules/stable-query-client/stable-query-client.rule.ts
  • packages/eslint-plugin-query/src/utils/ast-utils.ts
Files with no reviewable changes: 1
  • packages/eslint-plugin-query/src/utils/ast-utils.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The stable-query-client fixer and ASTUtils.getReferencedExpressionByIdentifier now use context.sourceCode directly. The previous fallbacks to older ESLint source-code and scope APIs were removed.

Changes: ESLint source access

Layer / File(s) Summary
Use context.sourceCode directly
packages/eslint-plugin-query/src/utils/ast-utils.ts, packages/eslint-plugin-query/src/rules/stable-query-client/stable-query-client.rule.ts		 The AST utility obtains scope through context.sourceCode.getScope(node). The fixer reads expression text from context.sourceCode. Both changes remove fallbacks to older ESLint APIs.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Suggested reviewers: dogpawhat

Merge Risk: Minimal · up to 4760f

The source-access update is compatible with all supported ESLint versions and does not introduce an actionable merge risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and specifically describes the main change: removing obsolete ESLint compatibility fallbacks because the peer range starts at ESLint 8.57.0.
Description check Passed The description explains the change and motivation, completes all checklist items, and records the release impact classification.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12325

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12325

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12325

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12325

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12325

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12325

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12325

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12325

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12325

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12325

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12325

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12325

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12325

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12325

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12325

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12325

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12325

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12325

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12325

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12325

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12325

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12325

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12325

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12325

commit: 6cd4504

@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.76 KB (0%)
react minimal 8.59 KB (0%)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon