fix(solid-query): attach 'useQueries' through the provider's hydration channel - #11186
Open
lazerg wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
useQueriesnever got the hydration coordination that #11168 added touseBaseQuery. It builds its ownQueriesObserverand subscribes from an effect, so a component that hydrates before its dehydrated entries have arrived on the SSR stream attaches to a cold cache and refetches on mount, even for data that is well insidestaleTime.The subscription now goes through the same coordinator. With a provider in place,
useQueriesattaches once every one of its queries has been primed, or once the channel reports itself done. OneQueriesObservercovers all of the queries, so it can only attach when the last one is ready.QueryClientProvidercloses the channel right away on a fresh client mount, detected with the samePromiseexecutor probeuseBaseQueryuses, so an app without SSR never waits.For the test, the streaming fixture gains a
useQueriesin the shell whose query settles after the slow boundary, so its entry only rides the final flush. Before the change it refetches at shell hydration.Fixes #11185
✅ Checklist
Local verification:
vitest runonsolid-query(330 tests),solid-query-persist-clientandsolid-query-devtools, all green with no type errors; eslint and prettier clean.🚀 Release Impact