Skip to content

fix: harden maintainer setup and release checks - #291

Merged
LadyBluenotes merged 4 commits into
feat/reusable-check-workflowfrom
fix/maintainer-release-hardening
Sep 13, 2026
Merged

fix: harden maintainer setup and release checks#291
LadyBluenotes merged 4 commits into
feat/reusable-check-workflowfrom
fix/maintainer-release-hardening

Conversation

@LadyBluenotes

@LadyBluenotes LadyBluenotes commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🎯 Changes

Stacked on #290.

  • Maintainer setup preflights instruction, registration, and distribution changes before any write. Previously it could write through repository symlinks before finishing input validation.
  • Recurring commands use the installed CLI instead of fetching a possibly different Intent version. Explicit bootstrap instructions keep their version selection.
  • JavaScript/JSDoc and JSX validation covers public source entries and Markdown fence boundaries. Maintainer checks reuse example results instead of compiling them twice.
  • Fixes false Router errors caused by disabled strict null checks and missing shorthand-name handling.
  • CI and workflow changes live in feat: run reusable skill checks and prepare repair patches #290, docs in docs: cover the maintainer workflow and release checks #259, and the repair command in feat: add conservative skill repairs #292.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr (run pnpm build:all first).

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 220fbb63-c818-457d-9c5e-6c3d4a43cabf

📥 Commits

Reviewing files that changed from the base of the PR and between 13ba627 and d31fad1.

📒 Files selected for processing (28)
  • .changeset/maintainer-release-hardening.md
  • packages/intent/meta/generate-skill/SKILL.md
  • packages/intent/meta/tree-generator/SKILL.md
  • packages/intent/src/commands/install/command.ts
  • packages/intent/src/commands/install/guidance.ts
  • packages/intent/src/commands/maintainer.ts
  • packages/intent/src/commands/support.ts
  • packages/intent/src/commands/validate.ts
  • packages/intent/src/hooks/policy.ts
  • packages/intent/src/maintainer/distribution.ts
  • packages/intent/src/maintainer/existing.ts
  • packages/intent/src/maintainer/project.ts
  • packages/intent/src/setup/project-setup.ts
  • packages/intent/src/shared/command-runner.ts
  • packages/intent/src/skills/paths.ts
  • packages/intent/src/validate/blocks.ts
  • packages/intent/tests/cli.test.ts
  • packages/intent/tests/discovery-safety.test.ts
  • packages/intent/tests/hooks-install.test.ts
  • packages/intent/tests/install-writer.test.ts
  • packages/intent/tests/integration/packed-release.test.ts
  • packages/intent/tests/maintainer-install.test.ts
  • packages/intent/tests/maintainer.test.ts
  • packages/intent/tests/review.test.ts
  • packages/intent/tests/skill-paths.test.ts
  • packages/intent/tests/stale-command.test.ts
  • packages/intent/tests/validate-blocks.test.ts
  • packages/intent/tests/workflow-review.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d31fad1

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 40s View ↗
nx run-many --targets=build ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-13 19:35:52 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@291

commit: d31fad1

@codspeed-hq

codspeed-hq Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks

Comparing fix/maintainer-release-hardening (d31fad1) with feat/reusable-check-workflow (13ba627)

Open in CodSpeed

@LadyBluenotes
LadyBluenotes marked this pull request as ready for review September 13, 2026 05:20
@LadyBluenotes
LadyBluenotes requested a review from a team as a code owner September 13, 2026 05:20
@LadyBluenotes LadyBluenotes mentioned this pull request Sep 13, 2026
Merged
4 tasks
@LadyBluenotes
LadyBluenotes force-pushed the fix/maintainer-release-hardening branch from 9a65986 to 54538e5 Compare September 13, 2026 06:23
This was referenced Sep 13, 2026
Merged
Open
@LadyBluenotes
LadyBluenotes force-pushed the fix/maintainer-release-hardening branch from 945fb02 to 0ade167 Compare September 13, 2026 17:57
@LadyBluenotes
LadyBluenotes changed the base branch from docs/maintainer-release to feat/reusable-check-workflow September 13, 2026 17:57
This was referenced Sep 13, 2026
Merged
Merged
Merged
@LadyBluenotes
LadyBluenotes added this pull request to stack #293 September 13, 2026 19:00
LadyBluenotes added a commit that referenced this pull request Sep 13, 2026
@LadyBluenotes
Merge Windows test corrections from PR #291
4866a3d
LadyBluenotes added a commit that referenced this pull request Sep 13, 2026
@LadyBluenotes
Merge packaged link assertion fix from PR #291
80ed89d
@LadyBluenotes
LadyBluenotes merged commit 909f5fc into main Sep 13, 2026
10 checks passed
@LadyBluenotes
LadyBluenotes deleted the fix/maintainer-release-hardening branch September 13, 2026 19:53
@github-actions github-actions Bot mentioned this pull request Sep 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schiller-manuel schiller-manuel schiller-manuel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LadyBluenotes @schiller-manuel