Skip to content

feat: record every pending review item in one command - #288

Merged
LadyBluenotes merged 4 commits into
feat/setup-registers-existingfrom
feat/review-one-shot
Sep 13, 2026
Merged

LadyBluenotes merged 4 commits into
feat/setup-registers-existingfrom
feat/review-one-shot

Conversation

@LadyBluenotes

@LadyBluenotes LadyBluenotes commented Sep 12, 2026

Copy link
Copy Markdown
Member

Stack (merge in order): #198#287#288#289#290#291#292. Docs for the whole stack are in #259, based on #290.

  • maintainer review --unchanged <reason> and --updated <reason> record that outcome for every pending item in one command.
  • Same fingerprint and problem checks as --record, and the same .intent/review-state.json. Evidence is the reviewed revision plus each item's changed files, so only the reason is typed.
  • Rejected when combined with each other, --interactive, --json, or --record, when the reason is blank, or when nothing is pending.
  • The check failure message and the source-review procedure name the new flags first.
  • Named --unchanged rather than --no-change because cac parses --no-<name> as a negation.
  • Release notes appended to the unpublished interactive-maintainer-review changeset.

Add `maintainer review --unchanged <reason>` and `--updated <reason>`.
Each records the given outcome for every pending item through the
existing fingerprint checks, with the reviewed revision and the files
each item changed as evidence, so a maintainer who already knows the
answer does not walk a menu or hand-edit a JSON report.

The flag is `--unchanged` rather than `--no-change` because cac parses
`--no-<name>` as the negation of `--<name>`.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 84e7ac9a-0293-487f-9b55-b64cf701f56b

📥 Commits

Reviewing files that changed from the base of the PR and between 7ca9700 and d4bff46.

📒 Files selected for processing (6)
  • .changeset/interactive-maintainer-review.md
  • packages/intent/meta/generate-skill/references/source-review.md
  • packages/intent/src/cli.ts
  • packages/intent/src/commands/maintainer.ts
  • packages/intent/src/review/review.ts
  • packages/intent/tests/review-workflow.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 12, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d4bff46

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 47s View ↗
nx run-many --targets=build ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-13 19:35:47 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@288

commit: d4bff46

@codspeed-hq

codspeed-hq Bot commented Sep 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks


Comparing feat/review-one-shot (d4bff46) with feat/setup-registers-existing (7ca9700)

Open in CodSpeed

@LadyBluenotes
LadyBluenotes merged commit e25a57e into main Sep 13, 2026
10 checks passed
@LadyBluenotes
LadyBluenotes deleted the feat/review-one-shot branch September 13, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant